Thread (24 messages) 24 messages, 5 authors, 2020-09-16

Re: [PATCH RESEND 2/4] scsi: sg: implement BLKSSZGET

flat view

From: Christoph Hellwig <hch@lst.de>
Date: 2020-09-11 06:48:50
Also in: linux-scsi

Possibly related (same subject, not in this thread)

On Fri, Sep 11, 2020 at 10:52:19AM +0800, Tom Yan wrote:
quoted
How is that an advantage?  Applications that works with block devices
don't really work with a magic passthrough character device.
You must assume that there are applications already assuming that
work. (And it will, at least in some cases, if this series get
merged.)
Why "must" I assume that?
And you have not been giving me a solid point anyway, as I said, it's
just queue_*() at the end of the day; regardless of whether those
would work in all sg cases, we have been using them in the sg driver
anyway.

And it's not like we have to guarantee that (the) ioctls can work in
every case anyway, right? (Especially when they aren't named SG_*).
No.  While it is unfortunte we have all kinds of cases of ioctls working
differnetly on different devices.
I mean, what's even your point? How do you propose we fix this?
I propose to not "fix" anything, because nothing is broken except for
maybe a lack of documentation.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help