Re: [PATCH v2 2/2] net: socket: implement SO_DESCRIPTION

From
Pascal Bouchareine <hidden>
Date
2020-08-22 19:59:25
Also in
lkml, netdev
Reply to
David Miller, 2020-08-22
Thank you,

On Sat, Aug 22, 2020 at 12:36 PM David Miller [off-list ref] wrote:
quoted
We ignore optlen and constrain the string to a static max size

Signed-off-by: Pascal Bouchareine <redacted>
This change is really a non-starter unless the information gets
published somewhere where people actually look at dumped sockets, and
that's inet_diag and friends.
Would it make sense to also make UDIAG_SHOW_NAME use sk_description?
(And keep the existing change - setsockopt + show_fd_info via
/proc/.../fdinfo/..)

I would feel like adding a pid information (and what else am I missing
here) to inet_diag might also be a good improvement then?

I understand that users have to scan /proc to find the FDs, matching
the inode number for the socket to find the owning process today.

If that's of interest I can explore that too
Thread (22 messages) 22 messages, 7 authors, last reply 2020-08-23
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help