Thread (55 messages) flat view 55 messages, 9 authors, 2020-02-18

Re: [PATCHv8 02/34] lib/vdso: make do_hres and do_coarse as __always_inline

From: Andrei Vagin <hidden>
Date: 2020-01-13 05:27:44
Also in: lkml

On Fri, Jan 10, 2020 at 4:02 AM Thomas Gleixner [off-list ref] wrote:
Vincenzo Frascino [off-list ref] writes:
quoted
On 1/10/20 11:42 AM, Thomas Gleixner wrote:
quoted
quoted
quoted
+» » /*·goto·allows·to·avoid·extra·inlining·of·do_hres.·*/
+» » goto·out_hres;
What is the performance impact of "goto out_hres"?
On x86 it's invisible at least in my limited testing.
On arm64 as well based on mine as well. Shall we keep the code more readable
here (without goto)?
The delta patch below makes it readable again and also avoids the double
inlining. Quick testing shows no difference.
My tests show no difference too and the code looks more readable. Thanks!
Thanks,

        tglx
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help