Thread (5 messages) flat view 5 messages, 2 authors, 2020-01-09

Re: [PATCH][RESEND v5] x86/resctrl: Add task resctrl information display

From: Yu Chen <yu.c.chen@intel.com>
Date: 2020-01-09 17:46:56
Also in: linux-fsdevel, lkml

Hi Chris,
On Thu, Jan 09, 2020 at 02:24:44PM +0000, Chris Down wrote:
Chen Yu writes:
quoted
+#ifdef CONFIG_PROC_CPU_RESCTRL
+
+/*
+ * A task can only be part of one control
+ * group and of one monitoring group which
+ * is associated to that control group.
+ * So one line is simple and clear enough:
Can we please avoid using the word "control group" to describe these? It's
extremely confusing for readers since it's exactly the same word as used for
actual cgroups, especially since those are also a form of "resource
control"...

Doesn't official documentation refer to them as "resource groups" to avoid
this?
Right, how abut changing change this description to:
control group  ->   resctrl allocation group
monitor group  ->   resctrl monitor group?

Yes, the Documentation/x86/resctrl_ui.rst described them as
"Resource Control feature", which is composed of allocation
and monitor, so distinguish them as above seems to be appropriate.

Thanks,
Chenyu
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help