Re: [RFC PATCH v2 3/5] btrfs: generalize btrfs_lookup_bio_sums_dio()

On 15.10.19 г. 21:42 ч., Omar Sandoval wrote:

From: Omar Sandoval <redacted>

This isn't actually dio-specific; it just looks up the csums starting at
the given offset instead of using the page index. Rename it to
btrfs_lookup_bio_sums_at_offset() and add the dst parameter. We might
even want to expose __btrfs_lookup_bio_sums() as the public API instead
of having two trivial wrappers, but I'll leave that for another day.

IMO exposing btrfs_lookup_bio_sums and adding proper kernel doc for its
parameters is the correct way forward. Consider doing this if the
general direction of this patchset is accepted and before sending the
final revision.