On 25-Jul 13:41, Michal Koutný wrote:

On Thu, Jul 18, 2019 at 07:17:43PM +0100, Patrick Bellasi [off-list ref] wrote:

quoted

+static ssize_t cpu_uclamp_min_write(struct kernfs_open_file *of,
+				    char *buf, size_t nbytes,
+				    loff_t off)
+{
[...]
+static ssize_t cpu_uclamp_max_write(struct kernfs_open_file *of,
+				    char *buf, size_t nbytes,
+				    loff_t off)
+{
[...]

These two functions are almost identical yet not trivial. I think it
wouldn be better to have the code at one place only and distinguish by
the passed clamp_id.

Good point, since the removal of the boundary checks on values we now
have two identical methods. I'll factor our the common code in a
single function.

Cheers,
Patrick

-- 
#include <best/regards.h>

Patrick Bellasi