Re: [PATCH v12 1/6] sched/core: uclamp: Extend CPU's cgroup controller
From: Michal Koutný <mkoutny@suse.com>
Date: 2019-07-25 11:41:12
Also in:
cgroups, linux-pm, lkml
On Thu, Jul 18, 2019 at 07:17:43PM +0100, Patrick Bellasi [off-list ref] wrote:
+static ssize_t cpu_uclamp_min_write(struct kernfs_open_file *of,
+ char *buf, size_t nbytes,
+ loff_t off)
+{
[...]
+static ssize_t cpu_uclamp_max_write(struct kernfs_open_file *of,
+ char *buf, size_t nbytes,
+ loff_t off)
+{
[...]These two functions are almost identical yet not trivial. I think it wouldn be better to have the code at one place only and distinguish by the passed clamp_id.
Attachments
- signature.asc [application/pgp-signature] 833 bytes