Re: [PATCH v9 12/16] sched/core: uclamp: Extend CPU's cgroup controller

On 31-May 08:35, Tejun Heo wrote:

Hello, Patrick.

Hi Tejun!

On Wed, May 15, 2019 at 10:44:55AM +0100, Patrick Bellasi wrote:

quoted

Extend the CPU controller with a couple of new attributes util.{min,max}
which allows to enforce utilization boosting and capping for all the
tasks in a group. Specifically:

- util.min: defines the minimum utilization which should be considered
	    i.e. the RUNNABLE tasks of this group will run at least at a
		 minimum frequency which corresponds to the util.min
		 utilization

- util.max: defines the maximum utilization which should be considered
	    i.e. the RUNNABLE tasks of this group will run up to a
		 maximum frequency which corresponds to the util.max
		 utilization

Let's please use a prefix which is more specific.  It's clamping the
utilization estimates of the member tasks which in turn affect
scheduling / frequency decisions but cpu.util.max reads like it's
gonna limit the cpu utilization directly.  Maybe just use uclamp?

Being too specific does not risk to expose implementation details?

If that's not a problem and Peter likes:

   cpu.uclamp.{min,max}

that's ok with me.

-- 
#include <best/regards.h>

Patrick Bellasi