Thread (42 messages) 42 messages, 5 authors, 2019-06-21

Re: [PATCH 02/25] vfs: Allow fsinfo() to query what's in an fs_context [ver #13]

flat view

From: David Howells <dhowells@redhat.com>
Date: 2019-06-21 13:13:02
Also in: linux-fsdevel, lkml

Christian Brauner [off-list ref] wrote:
quoted
 static int vfs_fsinfo_fd(unsigned int fd, struct fsinfo_kparams *params)
 {
 	struct fd f = fdget_raw(fd);
You're using fdget_raw() which means you want to allow O_PATH fds but
below you're checking whether the f_ops correspond to
fscontext_fops. If it's an O_PATH
It can't be.  The only way to get an fs_context fd is from fsopen() or
fspick() - neither of which allow O_PATH to be specified.

If you tried to go through /proc/pid/fd with open(O_PATH), I think you'd get
the symlink, not the target.

David
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help