[PATCH for 5.2 00/12] Restartable Sequences selftests updates · Mathieu Desnoyers <mathieu.desnoyers@efficios.com> · 2019-04-29
[PATCH for 5.2 01/12] rseq/selftests: x86: Work-around bogus gcc-8 optimisation · Mathieu Desnoyers <mathieu.desnoyers@efficios.com> · 2019-04-29
[PATCH for 5.2 04/12] rseq/selftests: Use __rseq_handled symbol to coexist with glibc · Mathieu Desnoyers <mathieu.desnoyers@efficios.com> · 2019-04-29
[PATCH for 5.2 11/12] rseq/selftests: mips: use break instruction for RSEQ_SIG · Mathieu Desnoyers <mathieu.desnoyers@efficios.com> · 2019-04-29
[PATCH for 5.2 02/12] rseq/selftests: Add __rseq_exit_point_array section for debuggers · Mathieu Desnoyers <mathieu.desnoyers@efficios.com> · 2019-04-29
[PATCH for 5.2 12/12] rseq/selftests: add -no-integrated-as for clang · Mathieu Desnoyers <mathieu.desnoyers@efficios.com> · 2019-04-29
Re: [PATCH for 5.2 12/12] rseq/selftests: add -no-integrated-as for clang · Nick Desaulniers <ndesaulniers@google.com> · 2019-04-29
Re: [PATCH for 5.2 12/12] rseq/selftests: add -no-integrated-as for clang · Mathieu Desnoyers <mathieu.desnoyers@efficios.com> · 2019-04-29
Re: [PATCH for 5.2 12/12] rseq/selftests: add -no-integrated-as for clang · Nick Desaulniers <ndesaulniers@google.com> · 2019-04-29
[PATCH for 5.2 10/12] rseq/selftests: powerpc code signature: generate valid instructions · Mathieu Desnoyers <mathieu.desnoyers@efficios.com> · 2019-04-29
[PATCH for 5.2 09/12] rseq/selftests: aarch64 code signature: handle big-endian environment · Mathieu Desnoyers <mathieu.desnoyers@efficios.com> · 2019-04-29
[PATCH for 5.2 08/12] rseq/selftests: arm: use udf instruction for RSEQ_SIG · Mathieu Desnoyers <mathieu.desnoyers@efficios.com> · 2019-04-29
[PATCH v2 for 5.2 08/12] rseq/selftests: arm: use udf instruction for RSEQ_SIG · Mathieu Desnoyers <mathieu.desnoyers@efficios.com> · 2019-05-03
Re: [PATCH v2 for 5.2 08/12] rseq/selftests: arm: use udf instruction for RSEQ_SIG · Mathieu Desnoyers <mathieu.desnoyers@efficios.com> · 2019-06-06
Re: [PATCH v2 for 5.2 08/12] rseq/selftests: arm: use udf instruction for RSEQ_SIG · Mathieu Desnoyers <mathieu.desnoyers@efficios.com> · 2019-06-08
[PATCH for 5.2 06/12] rseq/selftests: x86: use ud1 instruction as RSEQ_SIG opcode · Mathieu Desnoyers <mathieu.desnoyers@efficios.com> · 2019-04-29
[PATCH for 5.2 07/12] rseq/selftests: s390: use trap4 for RSEQ_SIG · Mathieu Desnoyers <mathieu.desnoyers@efficios.com> · 2019-04-29
Re: [PATCH for 5.2 07/12] rseq/selftests: s390: use trap4 for RSEQ_SIG · shuah <shuah@kernel.org> · 2019-05-16
Re: [PATCH for 5.2 07/12] rseq/selftests: s390: use trap4 for RSEQ_SIG · Mathieu Desnoyers <mathieu.desnoyers@efficios.com> · 2019-05-16
[PATCH for 5.2 05/12] rseq/selftests: s390: use jg instruction for jumps outside of the asm · Mathieu Desnoyers <mathieu.desnoyers@efficios.com> · 2019-04-29
[PATCH for 5.2 03/12] rseq/selftests: Introduce __rseq_cs_ptr_array, rename __rseq_table to __rseq_cs · Mathieu Desnoyers <mathieu.desnoyers@efficios.com> · 2019-04-29
Re: [PATCH for 5.2 00/12] Restartable Sequences selftests updates · Mathieu Desnoyers <mathieu.desnoyers@efficios.com> · 2019-05-03
Re: [PATCH for 5.2 00/12] Restartable Sequences selftests updates · shuah <shuah@kernel.org> · 2019-05-03
Re: [PATCH for 5.2 00/12] Restartable Sequences selftests updates · Mathieu Desnoyers <mathieu.desnoyers@efficios.com> · 2019-05-03
Re: [PATCH for 5.2 00/12] Restartable Sequences selftests updates · Joe Perches <joe@perches.com> · 2019-05-03
Re: [PATCH for 5.2 00/12] Restartable Sequences selftests updates · shuah <shuah@kernel.org> · 2019-05-03

Re: [PATCH for 5.2 00/12] Restartable Sequences selftests updates

From: Joe Perches <joe@perches.com>
Date: 2019-05-03 21:46:34
Also in: lkml

On Fri, 2019-05-03 at 15:22 -0400, Mathieu Desnoyers wrote:

----- On May 3, 2019, at 2:53 PM, shuah shuah@kernel.org wrote:

quoted

ERROR: need consistent spacing around '%' (ctx:WxV)
#227: FILE: tools/testing/selftests/rseq/rseq-x86.h:104:
+		RSEQ_ASM_CMP_CPU_ID(cpu_id, RSEQ_CPU_ID_OFFSET(%[rseq_abi]), %l[error1])

Will you be able to fix them and resend?

[]

(CCing the che checkpatch maintainers)

checkpatch appears to be wrong for these errors. I suspect it thinks those are
'%' modulo operators (for which the style requires space before/after),
but those are actually part of the asm input and goto target operands.

checkpatch doesn't really understand asm.
Ignore checkpatch when it's silly.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help