Re: [PATCH v2 0/3] initramfs: add support for xattrs in the initial ram disk
From: Roberto Sassu <roberto.sassu@huawei.com>
Date: 2019-05-13 07:49:03
Also in:
linux-fsdevel, linux-integrity, lkml
On 5/12/2019 9:43 PM, Arvind Sankar wrote:
On Sun, May 12, 2019 at 05:05:48PM +0000, Rob Landley wrote:quoted
On 5/12/19 7:52 AM, Mimi Zohar wrote:quoted
On Sun, 2019-05-12 at 11:17 +0200, Dominik Brodowski wrote:quoted
On Thu, May 09, 2019 at 01:24:17PM +0200, Roberto Sassu wrote:quoted
This proposal consists in marshaling pathnames and xattrs in a file called .xattr-list. They are unmarshaled by the CPIO parser after all files have been extracted.Couldn't this parsing of the .xattr-list file and the setting of the xattrs be done equivalently by the initramfs' /init? Why is kernel involvement actually required here?It's too late. The /init itself should be signed and verified.If the initramfs cpio.gz image was signed and verified by the extractor, how is the init in it _not_ verified? RoWouldn't the below work even before enforcing signatures on external initramfs: 1. Create an embedded initramfs with an /init that does the xattr parsing/setting. This will be verified as part of the kernel image signature, so no new code required. 2. Add a config option/boot parameter to panic the kernel if an external initramfs attempts to overwrite anything in the embedded initramfs. This prevents overwriting the embedded /init even if the external initramfs is unverified.
Unfortunately, it wouldn't work. IMA is already initialized and it would verify /init in the embedded initial ram disk. The only reason why opening .xattr-list works is that IMA is not yet initialized (late_initcall vs rootfs_initcall). Allowing a kernel with integrity enforcement to parse the CPIO image without verifying it first is the weak point. However, extracted files are not used, and before they are used they are verified. At the time they are verified, they (included /init) must already have a signature or otherwise access would be denied. This scheme relies on the ability of the kernel to not be corrupted in the event it parses a malformed CPIO image. Mimi suggested to use digital signatures to prevent this issue, but it cannot be used in all scenarios, since conventional systems generate the initial ram disk locally. Roberto -- HUAWEI TECHNOLOGIES Duesseldorf GmbH, HRB 56063 Managing Director: Bo PENG, Jian LI, Yanli SHI