Thread (62 messages) flat view 62 messages, 5 authors, 2019-04-17

Re: [PATCH 01/17] fpga: dfl-fme-mgr: fix FME_PR_INTFC_ID register address.

From: Alan Tull <atull@kernel.org>
Date: 2019-03-25 17:29:02
Also in: linux-fpga, lkml

On Sun, Mar 24, 2019 at 10:23 PM Wu Hao [off-list ref] wrote:

Hi Hao,
FME_PR_INTFC_ID is used as compat_id for fpga manager and region,
but high 64 bits and low 64 bits of the compat_id are swapped by
mistake. This patch fixes this problem by fixing register address.

Signed-off-by: Wu Hao <redacted>
Acked-by: Alan Tull <atull@kernel.org>

Thanks,
Alan
quoted hunk ↗ jump to hunk
---
 drivers/fpga/dfl-fme-mgr.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/fpga/dfl-fme-mgr.c b/drivers/fpga/dfl-fme-mgr.c
index 76f3770..b3f7eee 100644
--- a/drivers/fpga/dfl-fme-mgr.c
+++ b/drivers/fpga/dfl-fme-mgr.c
@@ -30,8 +30,8 @@
 #define FME_PR_STS             0x10
 #define FME_PR_DATA            0x18
 #define FME_PR_ERR             0x20
-#define FME_PR_INTFC_ID_H      0xA8
-#define FME_PR_INTFC_ID_L      0xB0
+#define FME_PR_INTFC_ID_L      0xA8
+#define FME_PR_INTFC_ID_H      0xB0

 /* FME PR Control Register Bitfield */
 #define FME_PR_CTRL_PR_RST     BIT_ULL(0)  /* Reset PR engine */
--
2.7.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help