Thread (19 messages) 19 messages, 5 authors, 2018-11-06

Re: [PATCH v2 2/5] uapi: deprecate STATX_ALL

From: David Howells <dhowells@redhat.com>
Date: 2018-10-19 23:42:02
Also in: linux-fsdevel, lkml

Miklos Szeredi [off-list ref] wrote:
+/*
+ * This is deprecated, and shall remain the same value in the future.  To avoid
+ * confusion please use the equivalent (STATX_BASIC_STATS | STATX_BTIME)
+ * instead.
+ */
+#define STATX_ALL		0x00000fffU
The comment is misleading.  STATX_ALL is *not* equivalent to
STATX_BASIC_STATS | STATX_BTIME, even though it might be numerically the
same.  You would need to update the comment when you add STATX_ATTRIBUTES
to mention that also.

Apart from that, I'm okay with this.

Further, please provide a manpage update also.

David
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help