Thread (19 messages) 19 messages, 5 authors, 2018-11-06

Re: [PATCH v2 5/5] nfs: don't clear STATX_ATIME from result_mask

From: David Howells <dhowells@redhat.com>
Date: 2018-10-19 23:51:26
Also in: linux-fsdevel, lkml

Miklos Szeredi [off-list ref] wrote:
As per statx(2) man page only clear out flags that are unsupported by the
fs or have an unrepresentable value.  Atime is supported by NFS as long as
it's supported on the server.

So the STATX_ATIME flag should not be cleared in the result_mask if the
operation was requested on a MNT_NOATIME or MNT_NODIRATIME mount.

This patch doesn't change the revalidation algorithm in any way, just the
clearing of flags in stat->result_mask.

Signed-off-by: Miklos Szeredi <redacted>
Fixes: 9ccee940bd5b ("Support statx() mask and query flags parameters")
Cc: Trond Myklebust <redacted>
Reviewed-by: David Howells <dhowells@redhat.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help