Thread (33 messages) 33 messages, 4 authors, 2018-05-31

Re: [PATCH 1/6] lib/rhashtable: convert param sanitations to WARN_ON

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2018-05-28 09:41:04
Also in: lkml

On Thu, May 24, 2018 at 02:11:30PM -0700, Davidlohr Bueso wrote:
For the purpose of making rhashtable_init() unable to fail,
we can replace the returning -EINVAL with WARN_ONs whenever
the caller passes bogus parameters during initialization.

Signed-off-by: Davidlohr Bueso <redacted>
I don't really see why we need these WARN_ONs.  The problem should
be quite obvious when you're writing your code.

If you really want them perhaps add them to the ipc code instead?

Cheers,
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help