Re: [RFC v2 4/4] btrfs: verify symlinks with append/immutable flags
From: David Sterba <hidden>
Date: 2018-05-11 14:07:36
Also in:
linux-btrfs, linux-ext4, linux-fsdevel, linux-xfs, lkml
On Thu, May 10, 2018 at 04:13:59PM -0700, Luis R. Rodriguez wrote:
The Linux VFS does not allow a way to set append/immuttable
^^^^^^^^^^ Typo, in all 3 patches.
quoted hunk ↗ jump to hunk
attributes to symlinks, this is just not possible. If this is detected inform the user as the filesystem must be corrupted. Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org> --- fs/btrfs/inode.c | 9 +++++++++ 1 file changed, 9 insertions(+)diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index c4bdb597b323..d9c786be408c 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c@@ -3933,6 +3933,15 @@ static int btrfs_read_locked_inode(struct inode *inode) inode->i_op = &btrfs_dir_inode_operations; break; case S_IFLNK: + /* VFS does not allow setting these so must be corruption */ + if (IS_APPEND(inode) || IS_IMMUTABLE(inode)) { + ret = -EUCLEAN; + btrfs_crit(fs_info, + "corrupt symlink with append/immutable ino=%llu root=%llu\n",
no "\n" and please un-indent the string so it fits 80 columns.
+ btrfs_ino(BTRFS_I(inode)), + root->root_key.objectid); + goto make_bad;
I found some error handling issues, before the switch, there's btrfs_free_path and there's one more at the make_bad label. To fix that, please set path = NULL after the first btrfs_free_path, it can handle a NULL when it's called again. Next thing I'm not sure about are the ACLs that get initialized in some cases. There's cache_no_acl() that only resets the inode::i_acl and inode::i_default_acl, so I think this should be called too. Thanks.