Re: [PATCH] mm: don't show nr_indirectly_reclaimable in /proc/vmstat
flat view
From: Vlastimil Babka <hidden>
Date: 2018-04-25 19:38:40
Also in:
linux-mm, lkml
On 04/25/2018 09:14 PM, Roman Gushchin wrote:
Don't show nr_indirectly_reclaimable in /proc/vmstat, because there is no need in exporting this vm counter to the userspace, and some changes are expected in reclaimable object accounting, which can alter this counter.
Oh, you beat me to it, thanks.
Signed-off-by: Roman Gushchin <redacted> Cc: Vlastimil Babka <redacted> Cc: Matthew Wilcox <willy@infradead.org> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Alexander Viro <viro@zeniv.linux.org.uk> Cc: Michal Hocko <mhocko@suse.com> Cc: Johannes Weiner <hannes@cmpxchg.org>
Acked-by: Vlastimil Babka <redacted> Andrew, can you send this to Linus before the current rc period ends, please? Thanks, Vlastimil
quoted hunk ↗ jump to hunk
--- mm/vmstat.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)diff --git a/mm/vmstat.c b/mm/vmstat.c index 536332e988b8..a2b9518980ce 100644 --- a/mm/vmstat.c +++ b/mm/vmstat.c@@ -1161,7 +1161,7 @@ const char * const vmstat_text[] = { "nr_vmscan_immediate_reclaim", "nr_dirtied", "nr_written", - "nr_indirectly_reclaimable", + "", /* nr_indirectly_reclaimable */ /* enum writeback_stat_item counters */ "nr_dirty_threshold",@@ -1740,6 +1740,10 @@ static int vmstat_show(struct seq_file *m, void *arg) unsigned long *l = arg; unsigned long off = l - (unsigned long *)m->private; + /* Skip hidden vmstat items. */ + if (*vmstat_text[off] == '\0') + return 0; + seq_puts(m, vmstat_text[off]); seq_put_decimal_ull(m, " ", *l); seq_putc(m, '\n');