Thread (34 messages) 34 messages, 4 authors, 2018-03-28

Re: [PATCH v6 bpf-next 07/11] tracepoint: introduce kernel_tracepoint_find_by_name

From: Steven Rostedt <rostedt@goodmis.org>
Date: 2018-03-27 14:42:45
Also in: netdev

On Tue, 27 Mar 2018 10:18:24 -0400 (EDT)
Mathieu Desnoyers [off-list ref] wrote:
----- On Mar 27, 2018, at 10:07 AM, rostedt rostedt@goodmis.org wrote:
quoted
On Mon, 26 Mar 2018 19:47:02 -0700
Alexei Starovoitov [off-list ref] wrote:
  
quoted
From: Alexei Starovoitov <ast@kernel.org>

introduce kernel_tracepoint_find_by_name() helper to let bpf core
find tracepoint by name and later attach bpf probe to a tracepoint

Signed-off-by: Alexei Starovoitov <ast@kernel.org>  
Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>  
Steven showed preference for tracepoint_kernel_find_by_name() at some
point (starting with a tracepoint_ prefix). I'm find with either of
the names.
Yeah, I do prefer tracepoint_kernel_find_by_name() to stay consistent
with the other tracepoint functions. But we have
"for_each_kernel_tracepoint()" and not "for_each_tracepoint_kernel()",
thus we need to pick being consistent with one or the other. One answer
is to use tracpoint_kernel_find_by_name() and rename the for_each to
for_each_tracpoint_kernel().

-- Steve

Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Thanks,

Mathieu
quoted
Thanks for doing this Alexei!

One nit below.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help