Re: [PATCH bpf-next] bpf, tracing: unbreak lttng

On Mon, 26 Mar 2018 15:25:32 -0700
Alexei Starovoitov [off-list ref] wrote:

On 3/26/18 3:15 PM, Steven Rostedt wrote:

quoted

On Mon, 26 Mar 2018 15:08:45 -0700
Alexei Starovoitov [off-list ref] wrote:
 

quoted

for_each_kernel_tracepoint() is used by out-of-tree lttng module
and therefore cannot be changed.
Instead introduce kernel_tracepoint_find_by_name() to find
tracepoint by name.

Fixes: 9e9afbae6514 ("tracepoint: compute num_args at build time")
Signed-off-by: Alexei Starovoitov <ast@kernel.org>  

I'm curious, why can't you rebase? The first patch was never acked.  

because I think it makes sense to keep such things in the commit log
and in the separate diff, so next developer is aware of what kind of
minefield the tracpoints are.

This is a bunch of BS. It's not a minefield, and you can change that
function. Mathieu is perfectly fine in modifying his code to deal with
it. He has several times in the past. But I did not agree with the
approach you were taking, that is why I'm against it. You are playing
the straw man with this.

No wonder some maintainers refuse to add them.

Good grief. No! The reason maintainers refuse to add them is that
userspace can depend on them, and if that happens, it becomes an ABI.
Stop with this nonsense.

-- Steve