Re: [PATCH bpf-next] bpf, tracing: unbreak lttng

From
Alexei Starovoitov <hidden>
Date
2018-03-26 22:37:05
Also in
netdev
Reply to
Mathieu Desnoyers, 2018-03-26
On 3/26/18 3:30 PM, Mathieu Desnoyers wrote:
----- On Mar 26, 2018, at 6:08 PM, Alexei Starovoitov ast@kernel.org wrote:
[...]
quoted
#ifdef CONFIG_TRACEPOINTS
-void *
-for_each_kernel_tracepoint(void *(*fct)(struct tracepoint *tp, void *priv),
+void
+for_each_kernel_tracepoint(void (*fct)(struct tracepoint *tp, void *priv),
			   void *priv);
+struct tracepoint *kernel_tracepoint_find_by_name(const char *name);
#else
-static inline void *
-for_each_kernel_tracepoint(void *(*fct)(struct tracepoint *tp, void *priv),
+static inline void
+for_each_kernel_tracepoint(void (*fct)(struct tracepoint *tp, void *priv),
			   void *priv)
{
	return NULL;
}
This patch is not reverting to the old code properly. It introduces a
static inline void function that returns NULL. Please compile-test
with CONFIG_TRACEPOINTS=n before submitting a patch involving tracepoints.
right. good catch. v2 is coming.
Thread (9 messages) 9 messages, 4 authors, last reply 2018-03-27
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help