[PATCH 0/9 v5] No wait AIO · Goldwyn Rodrigues <hidden> · 2017-04-11
[PATCH 2/9] nowait aio: Introduce RWF_NOWAIT · Goldwyn Rodrigues <hidden> · 2017-04-11
[PATCH 1/9] Use RWF_* flags for AIO operations · Goldwyn Rodrigues <hidden> · 2017-04-11
Re: [PATCH 1/9] Use RWF_* flags for AIO operations · Christoph Hellwig <hch@infradead.org> · 2017-04-12
[PATCH 3/9] nowait aio: return if direct write will trigger writeback · Goldwyn Rodrigues <hidden> · 2017-04-11
[PATCH 4/9] nowait-aio: Introduce IOMAP_NOWAIT · Goldwyn Rodrigues <hidden> · 2017-04-11
[PATCH 5/9] nowait aio: return on congested block device · Goldwyn Rodrigues <hidden> · 2017-04-11
Re: [PATCH 5/9] nowait aio: return on congested block device · Christoph Hellwig <hch@infradead.org> · 2017-04-12
Re: [PATCH 5/9] nowait aio: return on congested block device · Goldwyn Rodrigues <hidden> · 2017-04-12
[PATCH 6/9] nowait aio: ext4 · Goldwyn Rodrigues <hidden> · 2017-04-11
[PATCH 7/9] nowait aio: xfs · Goldwyn Rodrigues <hidden> · 2017-04-11
[PATCH 9/9] nowait aio: Return -EOPNOTSUPP if filesystem does not support · Goldwyn Rodrigues <hidden> · 2017-04-11
Re: [PATCH 9/9] nowait aio: Return -EOPNOTSUPP if filesystem does not support · Christoph Hellwig <hch@infradead.org> · 2017-04-12
[PATCH 8/9] nowait aio: btrfs · Goldwyn Rodrigues <hidden> · 2017-04-11

Re: [PATCH 5/9] nowait aio: return on congested block device

From: Christoph Hellwig <hch@infradead.org>
Date: 2017-04-12 08:36:25
Also in: linux-block, linux-btrfs, linux-ext4, linux-fsdevel, linux-xfs

As mentioned last time around, this should be a REQ_NOWAIT flag so
that it can be easily passed down to the request layer.

quoted hunk ↗ jump to hunk

+static inline void bio_wouldblock_error(struct bio *bio)
+{
+	bio->bi_error = -EAGAIN;
+	bio_endio(bio);
+}

Please skip this helper..

+#define QUEUE_FLAG_NOWAIT      28	/* queue supports BIO_NOWAIT */

Please make the flag name a little more descriptive, this sounds like
it will never wait.