Re: [PATCH 5/9] nowait aio: return on congested block device

On 04/12/2017 03:36 AM, Christoph Hellwig wrote:

As mentioned last time around, this should be a REQ_NOWAIT flag so
that it can be easily passed dow? n to the request layer.

quoted

+static inline void bio_wouldblock_error(struct bio *bio)
+{
+	bio->bi_error = -EAGAIN;
+	bio_endio(bio);
+}

Please skip this helper..

Why? It is being called three times?
I am incorporating all the rest of the comments, besides this one. Thanks.

quoted

+#define QUEUE_FLAG_NOWAIT      28	/* queue supports BIO_NOWAIT */

Please make the flag name a little more descriptive, this sounds like
it will never wait.

-- 
Goldwyn