Re: [RFC PATCH v7 1/7] Restartable sequences system call

From
Peter Zijlstra <peterz@infradead.org>
Date
2016-08-10 19:15:38
Also in
lkml
Reply to
Mathieu Desnoyers, 2016-08-10
On Wed, Aug 10, 2016 at 01:26:04PM +0000, Mathieu Desnoyers wrote:
static bool rseq_update_cpu_id_event_counter(struct task_struct *t)
{
        union rseq_cpu_event u;

        u.e.cpu_id = raw_smp_processor_id();
        u.e.event_counter = ++t->rseq_event_counter;
        if (__put_user(u.v, &t->rseq->u.v))
                return false;
        trace_rseq_inc(t->rseq_event_counter);
I had not previously noticed the trace_* muck, but I would suggest
passing in t and leaving it up to the tracepoint implementation to pick
out the value.

Also, since this not only increments (it also updates the cpu number)
the naming is 'wrong'.
        return true;
}
Thread (64 messages) 64 messages, 6 authors, last reply 2016-08-11
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help