Re: [PATCH 1/1] Add virtio-input driver.

From
Gerd Hoffmann <kraxel@redhat.com>
Date
2015-03-23 14:27:49
Also in
lkml, virtualization
Reply to
Michael S. Tsirkin, 2015-03-23
  Hi,
quoted
quoted
quoted
You are doing leXXX everywhere, that's VERSION_1 dependency.
virtio_cread will do byteswaps differently without VERSION_1.
Just don't go there.
So to clarify, you dislike using __virtio32 in virtio input header?
Well, as I understand things __virtio32 implies byteorder depends on
whenever we are using VERSION_1 or not.  And non-transitional drivers
should not need it as everything is by definition little endian.

So, yes, your suggestion to just require VERSION_1 in the driver implies
in my eyes that there should be no reason to use __virtio32 instead of
__le32.

Or do I miss something here?

cheers,
  Gerd
Thread (21 messages) 21 messages, 6 authors, last reply 2015-03-23
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help