Re: [PATCH 1/1] Add virtio-input driver.

  Hi,

quoted

quoted

+static ssize_t serial_show(struct device *dev,
+                          struct device_attribute *attr, char *buf)
+{
+       struct input_dev *idev = to_input_dev(dev);
+       struct virtio_input *vi = input_get_drvdata(idev);
+       return sprintf(buf, "%s\n", vi->serial);
+}
+static DEVICE_ATTR_RO(serial);

What is serial? Serial number?

Yes.  You can (optionally) configure a serial number on the host side,
and if that is the case it'll show up here.

quoted

Can you set vi->idev->uniq to the virtio-bus path?

No, uniq can't be phys as phys is unique within the system while uniq is
like serial number or UUID and should never repeat.

Ok, so I guess I should just fill uniq with serial (if present).

cheers,
  Gerd