Re: [PATCH v1 1/6] eeprom: Add a simple EEPROM framework for eeprom providers
From: Paul Bolle <hidden>
Date: 2015-03-05 10:23:54
Also in:
linux-arm-kernel, linux-devicetree, lkml
On Thu, 2015-03-05 at 09:45 +0000, Srinivas Kandagatla wrote:
quoted hunk ↗ jump to hunk
--- /dev/null +++ b/drivers/eeprom/Kconfig@@ -0,0 +1,20 @@ +menuconfig EEPROM + bool "EEPROM Support"
EEPROM is a bool symbol.
quoted hunk ↗ jump to hunk
+ depends on OF + select REGMAP + help + Support for EEPROM alike devices. + + This framework is designed to provide a generic interface to EEPROM + from both the Linux Kernel and the userspace. + + If unsure, say no. + +if EEPROM + +config EEPROM_DEBUG + bool "EEPROM debug support" + help + Say yes here to enable debugging support. + +endifdiff --git a/drivers/eeprom/Makefile b/drivers/eeprom/Makefile new file mode 100644 index 0000000..e130079 --- /dev/null +++ b/drivers/eeprom/Makefile@@ -0,0 +1,9 @@ +# +# Makefile for eeprom drivers. +# + +ccflags-$(CONFIG_EEPROM_DEBUG) += -DDEBUG + +obj-$(CONFIG_EEPROM) += core.o
So core.o will be built-in (or not built at all, of course).
quoted hunk ↗ jump to hunk
+# Devicesdiff --git a/drivers/eeprom/core.c b/drivers/eeprom/core.c new file mode 100644 index 0000000..243e466 --- /dev/null +++ b/drivers/eeprom/core.c@@ -0,0 +1,208 @@ +/* + * EEPROM framework core. + * + * Copyright (C) 2015 Srinivas Kandagatla <srinivas.kandagatla@linaro.org> + * Copyright (C) 2013 Maxime Ripard <maxime.ripard@free-electrons.com> + * + * This file is licensed under the terms of the GNU General Public + * License version 2. This program is licensed "as is" without any + * warranty of any kind, whether express or implied. + */ + +#include <linux/device.h> +#include <linux/eeprom-provider.h> +#include <linux/export.h> +#include <linux/fs.h> +#include <linux/idr.h> +#include <linux/init.h> +#include <linux/module.h>
So I guess this header is not needed.
+#include <linux/of.h> +#include <linux/slab.h> +#include <linux/uaccess.h>
+module_exit(eeprom_exit);
And this will never be called.
+MODULE_AUTHOR("Srinivas Kandagatla <srinivas.kandagatla@linaro.org");
+MODULE_AUTHOR("Maxime Ripard <maxime.ripard@free-electrons.com");
+MODULE_DESCRIPTION("EEPROM Driver Core");
+MODULE_LICENSE("GPL");
And those four macros will basically be preprocessed away. But if you
actually want this code to be built modular too, and change EEPROM to
tristate, you probably want to use
MODULE_LICENSE("GPL v2");
here.
Paul Bolle