Re: [PATCH v5 3/8] crypto: AF_ALG: add AEAD support
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2014-12-22 11:23:53
Also in:
linux-crypto, lkml
On Sun, Dec 07, 2014 at 11:22:30PM +0100, Stephan Mueller wrote:
+static inline bool aead_sufficient_data(struct aead_ctx *ctx)
+{
+ unsigned as = crypto_aead_authsize(crypto_aead_reqtfm(&ctx->aead_req));
+
+ return (ctx->used >= (ctx->aead_assoclen + ctx->enc ? : as ));Is this supposed to be return (ctx->used >= (ctx->aead_assoclen + (ctx->enc ?: as)));
+static int aead_recvmsg(struct kiocb *unused, struct socket *sock,
+ struct msghdr *msg, size_t ignored, int flags)
+{...
+ err = -ENOMEM; + if (!aead_sufficient_data(ctx)) + goto unlock;
You should just block if there is insufficient input. Cheers, -- Email: Herbert Xu [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt