Re: [PATCH 1/3] kcmp: Move kcmp.h into uapi
From: Michael Ellerman <hidden>
Date: 2014-11-28 02:18:49
Also in:
lkml
On Thu, 2014-10-23 at 16:07 +1100, Michael Ellerman wrote:
kcmp.h appears to be part of the API, it's documented in kcmp(2), and the selftests/kcmp code uses it. So move it to uapi so it's actually exported.
Looks like this series fell through the cracks? It still applies on rc6. Should I resend? cheers
quoted hunk ↗ jump to hunk
Signed-off-by: Michael Ellerman <mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org> --- include/linux/kcmp.h | 13 +------------ include/uapi/linux/Kbuild | 1 + include/uapi/linux/kcmp.h | 17 +++++++++++++++++ 3 files changed, 19 insertions(+), 12 deletions(-) create mode 100644 include/uapi/linux/kcmp.hdiff --git a/include/linux/kcmp.h b/include/linux/kcmp.h index 2dcd1b3aafc8..9dfb23e1771b 100644 --- a/include/linux/kcmp.h +++ b/include/linux/kcmp.h@@ -1,17 +1,6 @@ #ifndef _LINUX_KCMP_H #define _LINUX_KCMP_H -/* Comparison type */ -enum kcmp_type { - KCMP_FILE, - KCMP_VM, - KCMP_FILES, - KCMP_FS, - KCMP_SIGHAND, - KCMP_IO, - KCMP_SYSVSEM, - - KCMP_TYPES, -}; +#include <uapi/linux/kcmp.h> #endif /* _LINUX_KCMP_H */diff --git a/include/uapi/linux/Kbuild b/include/uapi/linux/Kbuild index b70237e8bc37..1cf50d682dbf 100644 --- a/include/uapi/linux/Kbuild +++ b/include/uapi/linux/Kbuild@@ -209,6 +209,7 @@ header-y += ivtvfb.h header-y += ixjuser.h header-y += jffs2.h header-y += joystick.h +header-y += kcmp.h header-y += kd.h header-y += kdev_t.h header-y += kernel-page-flags.hdiff --git a/include/uapi/linux/kcmp.h b/include/uapi/linux/kcmp.h new file mode 100644 index 000000000000..84df14b37360 --- /dev/null +++ b/include/uapi/linux/kcmp.h@@ -0,0 +1,17 @@ +#ifndef _UAPI_LINUX_KCMP_H +#define _UAPI_LINUX_KCMP_H + +/* Comparison type */ +enum kcmp_type { + KCMP_FILE, + KCMP_VM, + KCMP_FILES, + KCMP_FS, + KCMP_SIGHAND, + KCMP_IO, + KCMP_SYSVSEM, + + KCMP_TYPES, +}; + +#endif /* _UAPI_LINUX_KCMP_H */