Thread (41 messages) 41 messages, 3 authors, 2014-11-21

Re: crypto: user - Allow get request with empty driver name

From: Herbert Xu <hidden>
Date: 2014-11-21 02:32:29
Also in: linux-crypto, lkml

On Thu, Nov 20, 2014 at 05:08:42PM +0100, Stephan Mueller wrote:
Am Donnerstag, 20. November 2014, 21:40:29 schrieb Herbert Xu:

Hi Herbert,
quoted
On Thu, Nov 20, 2014 at 02:10:00PM +0100, Stephan Mueller wrote:
quoted
What about the following

if (p->cru_driver_name[0]
If the driver name is not empty
quoted
quoted
	alg = crypto_alg_match(p, 1);
Do an exact match using the driver name
quoted
quoted
else

	alg = crypto_alg_match(p, 0);
Otherise use the generic name for a fuzzy match.
quoted
If cru_driver_name is not empty then exact will never be used, no?
If the code suggestion does not follow my words outlined above, I want my 
words to be considered ;-)

Yet, I am unsure where the code deviates from my words.
No I am asking how is this different from my patch?

Cheers,
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help