Re: kdbus: add code for buses, domains and endpoints

Hi,

On 10/31/2014 02:39 AM, Al Viro wrote:

On Wed, Oct 29, 2014 at 03:00:52PM -0700, Greg Kroah-Hartman wrote:

quoted

See Documentation/kdbus.txt for more details.

... which has nothing whatsoever on object lifetime rules.

True. That document only describes the external API exposed by the
driver towards userspace.

Could you
folks please document that somewhere?  What pins what, what state
transitions are possible, etc.

Hmm, I'll see whether I can write something up.

BTW, the calling conventions for your foo_new() are annoying - instead of
"return -E... or 0, storing the reference to new object in var parameter
passed as the last argument", could you please just return ERR_PTR(-E...)
on error, a pointer to new object on success and to hell with those
struct foo **foo in the argument lists?

No problem at all. We'll change that around.


Thanks for your feedback, much appreciated!

Daniel