Re: [PATCH V7 7/8] ptp: Added a clock driver for the IXP46x.
From: Pavel Machek <hidden>
Date: 2011-01-02 09:20:59
Also in:
lkml, netdev
On Sun 2011-01-02 10:12:33, Richard Cochran wrote:
On Sun, Jan 02, 2011 at 09:45:05AM +0100, Pavel Machek wrote:quoted
Hi!!quoted
+struct ixp46x_channel_ctl { + u32 Ch_Control; /* 0x40 Time Synchronization Channel Control */ + u32 Ch_Event; /* 0x44 Time Synchronization Channel Event */ + u32 TxSnapLo; /* 0x48 Transmit Snapshot Low Register */ + u32 TxSnapHi; /* 0x4C Transmit Snapshot High Register */CouldWeGetRidOfCamelCase?I agree that CamelCase is ugly and in bad taste. However, I make an exception when the register level programmer's manual uses this style. IMHO, it is better to use the exact same mnemonics as in the manual. That way, when the next person comes along to make a change to
Given the comments -- does manual really use camelCase crap? And... the identifiers actually combine camelCase with _. Better fix it. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html