Re: [PATCH V7 1/8] ntp: add ADJ_SETOFFSET mode bit

On Wed, 2010-12-22 at 05:57 +0900, Kuwahara,T. wrote:

How about this?

if (txc->modes & ADJ_OFFSET) {
	if (txc->constant == INT32_MIN) {
		/* step time */
	} else {
		/* slew time */
	}
}

This looks like magic behavior. Sort of a "knock twice and then say the
password" interface. I don't see why that would be better then adding a
clear new mode flag?

That said, I'm somehow against the idea of using the adjtimex syscall
for that purpose.

Could you expand on why you don't like this?

thanks
-john