Thread (43 messages) 43 messages, 8 authors, 2011-01-06

Re: [PATCH V7 1/8] ntp: add ADJ_SETOFFSET mode bit

From: john stultz <hidden>
Date: 2010-12-21 22:26:14
Also in: lkml, netdev

On Wed, 2010-12-22 at 05:57 +0900, Kuwahara,T. wrote:
How about this?

if (txc->modes & ADJ_OFFSET) {
	if (txc->constant == INT32_MIN) {
		/* step time */
	} else {
		/* slew time */
	}
}
This looks like magic behavior. Sort of a "knock twice and then say the
password" interface. I don't see why that would be better then adding a
clear new mode flag?

That said, I'm somehow against the idea of using the adjtimex syscall
for that purpose.
Could you expand on why you don't like this?

thanks
-john
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help