Re: [PATCH 0/2] Shared flags
From: Christoph Hellwig <hidden>
Date: 2008-11-11 08:52:11
Also in:
linux-fsdevel
On Mon, Nov 10, 2008 at 04:58:17PM +0300, Pavel Shilovsky wrote:
Hello! We have situation during our work with Wine and Cifs-client then we have to use sharing access policy to files and we used 3 free bits from 21 to 23 of attribute flag(it allows to do NT-semantic for opening files in open() and it is necessary for correct implementation of function NTCreateFile in Wine). We think that it'll be useful not only for us and we proffer to add into the file kernel/include/asm-generic/fcntl.h following flags: #define O_DENYREAD 004000000 /* Do not permit read access */ #define O_DENYWRITE 010000000 /* Do not permit write access */ #define O_DENYDELETE 020000000 /* Do not permit delete or rename operations*/
I'm not completely opposed to these, but the patches you postd are
rather incomplete:
(1) you need to add it to fcntl.h for those architetures not using the
generic fcntl.h or those who would have overlapping bits with the
generic defintions.
(2) you also need to enforce these semantics in the VFS for local
filesystems
Now if (2) doesn't cause too much overhead I would say it's fine, if not
I would rather avoid it.
Also please Cc the linux-api list for userspace API updates.
--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html