Re: [PATCH] fs: binfmt_em86: check return code of remove_arg_zero
From: Miguel Ojeda <hidden>
Date: 2021-01-06 02:59:08
Also in:
linux-fsdevel, lkml
On Tue, Dec 22, 2020 at 10:03 PM Nick Desaulniers [off-list ref] wrote:
remove_arg_zero is declared as __must_check. Looks like it can return -EFAULT on failure. Cc: Masahiro Yamada <masahiroy@kernel.org> Cc: Miguel Ojeda <redacted> Reported-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Cc'ing Alpha list too.
Alexander, fs-devel: pinging about this... We removed
ENABLE_MUST_CHECK in 196793946264 ("Compiler Attributes: remove
CONFIG_ENABLE_MUST_CHECK"), so this should be giving a warning now
unconditionally. In 5.12 it will likely become a build error.
Nick: thanks for the patch! (I missed it in December, sorry)
Reviewed-by: Miguel Ojeda <ojeda@kernel.org>
Cheers,
Miguel