Re: [PATCH 01/10] perf/core: Add macro to test for event exclusion flags
From: Mark Rutland <mark.rutland@arm.com>
Date: 2018-11-19 16:01:27
Also in:
linux-arm-kernel, linuxppc-dev, lkml
On Fri, Nov 16, 2018 at 10:24:04AM +0000, Andrew Murray wrote:
Add a macro that tests if any of the perf event exclusion flags are set on a given event. Signed-off-by: Andrew Murray <redacted>
Aside from the s/macro/function, or s/macro/helper/, this looks sound to me. Assuming you fix that up here and in subsequent commit messages, for this patch feel free to add: Acked-by: Mark Rutland <mark.rutland@arm.com> Mark.
quoted hunk ↗ jump to hunk
--- include/linux/perf_event.h | 9 +++++++++ 1 file changed, 9 insertions(+)diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h index 53c500f..89ee7fa 100644 --- a/include/linux/perf_event.h +++ b/include/linux/perf_event.h@@ -1004,6 +1004,15 @@ perf_event__output_id_sample(struct perf_event *event, extern void perf_log_lost_samples(struct perf_event *event, u64 lost); +static inline bool event_has_exclude_flags(struct perf_event *event) +{ + struct perf_event_attr *attr = &event->attr; + + return attr->exclude_idle || attr->exclude_user || + attr->exclude_kernel || attr->exclude_hv || + attr->exclude_guest || attr->exclude_host; +} + static inline bool is_sampling_event(struct perf_event *event) { return event->attr.sample_period != 0;-- 2.7.4