Re: [PATCH REBASED 3/6] s390: Add __down_read_killable()
From: Martin Schwidefsky <hidden>
Date: 2017-09-30 10:36:30
Also in:
linux-arch, linux-s390, lkml
From: Martin Schwidefsky <hidden>
Date: 2017-09-30 10:36:30
Also in:
linux-arch, linux-s390, lkml
On Sat, 30 Sep 2017 11:20:02 +0200 Heiko Carstens [off-list ref] wrote:
On Fri, Sep 29, 2017 at 07:06:18PM +0300, Kirill Tkhai wrote:quoted
Similar to __down_write_killable(), and read killable primitive. Signed-off-by: Kirill Tkhai <redacted> --- arch/s390/include/asm/rwsem.h | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-)diff --git a/arch/s390/include/asm/rwsem.h b/arch/s390/include/asm/rwsem.hFWIW, while looking into this patch I realized that we never optimized our rwsem primitives to make use of new atomic instructions. The generic rwsem header file however does, since it uses atomic ops which we did optimize. Even when compiling for old machines the generic version generates better code. Therefore I will remove the 15 years old s390 implementation and switch to the generic version instead.
Take care not to conflict with the queued spinlock/rwlock patches on the features branch. https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git/commit/?h=features&id=eb3b7b848fb3dd00f7a57d633d4ae4d194aa7865 Me thinks that what you have in mind is already done. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.