Thread (10 messages) 10 messages, 4 authors, 2015-07-17

Re: [3/3] IRQ: Print "unexpected IRQ" messages consistently across architectures

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2015-07-13 03:23:09
Also in: linux-arch, linux-m68k, linux-mips, linux-s390, linux-sh, linuxppc-dev, lkml

On Sun, 2015-12-07 at 22:02:11 UTC, Bjorn Helgaas wrote:
Many architectures use a variant of "unexpected IRQ trap at vector %x" to
log unexpected IRQs.  This is confusing because (a) it prints the Linux IRQ
number, but "vector" more often refers to a CPU vector number, and (b) it
prints the IRQ number in hex with no base indication, while Linux IRQ
numbers are usually printed in decimal.

Print the same text ("unexpected IRQ %d") across all architectures.

No functional change other than the output text.
There's already a fallback version in asm-generic, so shouldn't you instead
just delete all the versions that are identical to that?

eg. on powerpc we have:
 static inline void ack_bad_irq(unsigned int irq)
 {
-	printk(KERN_CRIT "unexpected IRQ trap at vector %02x\n", irq);
+	printk(KERN_CRIT "unexpected IRQ %d\n", irq);
 }
And the generic version is:
 #ifndef ack_bad_irq
 static inline void ack_bad_irq(unsigned int irq)
 {
-	printk(KERN_CRIT "unexpected IRQ trap at vector %02x\n", irq);
+	printk(KERN_CRIT "unexpected IRQ %d\n", irq);
 }
 #endif
So we can just delete the powerpc version?

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help