Thread (8 messages) 8 messages, 4 authors, 2015-05-18

Re: [PATCH] alpha: Wire up missing syscalls

From: Dave Jones <hidden>
Date: 2015-05-12 14:30:26
Also in: lkml

On Tue, May 12, 2015 at 08:59:52PM +1200, Michael Cree wrote:
 > On Sun, May 10, 2015 at 02:33:36AM +0800, Chen Gang wrote:
 > > The related warnings:
 > > 
 > >     CALL    scripts/checksyscalls.sh
 > >   <stdin>:1238:2: warning: #warning syscall seccomp not implemented [-Wcpp]
 > >   <stdin>:1241:2: warning: #warning syscall getrandom not implemented [-Wcpp]
 > >   <stdin>:1244:2: warning: #warning syscall memfd_create not implemented [-Wcpp]
 > >   <stdin>:1247:2: warning: #warning syscall bpf not implemented [-Wcpp]
 > >   <stdin>:1250:2: warning: #warning syscall execveat not implemented [-Wcpp]
 > 
 > Chen: Have you tested the syscalls you have wired up?
 > 
 > I have a suspicion that more is required to wire up the seccomp
 > syscall.

likewise sys_bpf judging by the absence of bpf_int_jit_compile and friends in arch/alpha
The weak symbols mean it probably compiles/links, but it doesn't actually do
anything, and now instead of -ENOSYS, anyone trying to actually use that syscall
on alpha will get weird results.

Shutting up warnings like this strikes me as the wrong thing to do.

	Dave
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help