Thread (3 messages) 3 messages, 2 authors, 2012-11-20

Re: [PATCH 1/1] alpha: Remove duplicate inclusion of asm/xchg.h

From: Sachin Kamat <hidden>
Date: 2012-11-20 03:24:59

On 20 November 2012 00:00, Michael Cree [off-list ref] wrote:
On Mon, Nov 19, 2012 at 04:41:39PM +0530, Sachin Kamat wrote:
quoted
asm/xchg.h was included twice.

Signed-off-by: Sachin Kamat <redacted>
---
 arch/alpha/include/asm/cmpxchg.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/alpha/include/asm/cmpxchg.h b/arch/alpha/include/asm/cmpxchg.h
index 429e8cd..8df1674 100644
--- a/arch/alpha/include/asm/cmpxchg.h
+++ b/arch/alpha/include/asm/cmpxchg.h
@@ -40,7 +40,6 @@
 #undef ____cmpxchg
 #define ____xchg(type, args...)              __xchg ##type(args)
 #define ____cmpxchg(type, args...)   __cmpxchg ##type(args)
-#include <asm/xchg.h>
asm/xchg.h is intended to be included twice.  Your patch will break
compilation.
I did not realise it. I thought it was an unconditional include. Sorry
for the noise.
Cheers
Michael.


-- 
With warm regards,
Sachin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help