On Wed, Sep 19, 2012 at 4:37 PM, Stephen Rothwell [off-list ref] wrote:

Hi,

On Mon, 17 Sep 2012 13:22:54 +0200 Thierry Reding [off-list ref] wrote:

quoted

diff --git a/drivers/pci/setup-irq.c b/drivers/pci/setup-irq.c
index 270ae7b..3d61ce3 100644
--- a/drivers/pci/setup-irq.c
+++ b/drivers/pci/setup-irq.c

@@ -17,6 +17,11 @@
 #include <linux/ioport.h>
 #include <linux/cache.h>

+void __weak pcibios_update_irq(struct pci_dev *dev, int irq)
+{
+     dev_dbg(&dev->dev, "Assigning IRQ %02d\n", irq);
+     pci_write_config_byte(dev, PCI_INTERRUPT_LINE, irq);
+}

 static void
 pdev_fixup_irq(struct pci_dev *dev,

Didn't we have a problem with some compiler versions when the weak
definition was in the same file as the call (there is a call to this
function in drivers/pci/setup-irq.c)?

There was such a bug, but as far as I know, we aren't worrying about
it anymore: https://lkml.org/lkml/2011/7/4/9