Re: [PATCH] fix modpost when CONFIG_ALPHA_TSUNAMI=y
From: Michael Cree <hidden>
Date: 2012-02-18 22:29:43
Also in:
lkml, stable
On 19/02/12 10:24, Jim Faulkner wrote:
Linux 3.2.6 fails to modpost on my alpha machine when CONFIG_ALPHA_TSUNAMI=y. Linux 3.3-rc3 does not appear to have a fix for this bug, so is likely also affected. I've attached a patch which fixes this issue. I have tested this patch on Linux 3.2.6 successfully, and the patch also applies cleanly to Linux 3.3-rc3.
quoted hunk ↗ jump to hunk
diff -uNr linux-3.3-rc3/arch/alpha/kernel/core_tsunami.c linux-3.3-rc3.patched/arch/alpha/kernel/core_tsunami.c--- linux-3.3-rc3/arch/alpha/kernel/core_tsunami.c 2012-02-08 22:21:53.000000000 -0500 +++ linux-3.3-rc3.patched/arch/alpha/kernel/core_tsunami.c 2012-02-18 16:07:12.859977887 -0500@@ -11,6 +11,7 @@ #include <asm/core_tsunami.h> #undef __EXTERN_INLINE +#include <linux/module.h>
Wouldn't <linux/exports.h> be better? I seem to recall that this was a problem with EXPORT_SYMBOL not being defined and I see my own personal fix (which I had completely forgotten to send upstream) was to include <linux/exports.h>
#include <linux/types.h> #include <linux/pci.h> #include <linux/sched.h>
Cheers Michael.