Re: [PATCH] sched: provide scheduler_ipi() callback in response to smp_send_reschedule()
From: Benjamin Herrenschmidt <hidden>
Date: 2011-02-06 23:26:32
Also in:
linux-arch, linux-arm-kernel, linux-mips, linux-um, linuxppc-dev, virtualization, xen-devel
Subsystem:
linux for powerpc (32-bit and 64-bit), the rest · Maintainers:
Madhavan Srinivasan, Linus Torvalds
Possibly related (same subject, not in this thread)
- 2011-01-24 · Re: [PATCH] sched: provide scheduler_ipi() callback in response to smp_send_reschedule() · Ralf Baechle <hidden>
- 2011-01-17 · [PATCH] sched: provide scheduler_ipi() callback in response to smp_send_reschedule() · peterz@infradead.org (Peter Zijlstra)
- 2011-01-17 · [PATCH] sched: provide scheduler_ipi() callback in response to smp_send_reschedule() · benh@kernel.crashing.org (Benjamin Herrenschmidt)
- 2011-01-17 · Re: [PATCH] sched: provide scheduler_ipi() callback in response to smp_send_reschedule() · David Daney <hidden>
- 2011-01-17 · Re: [PATCH] sched: provide scheduler_ipi() callback in response to smp_send_reschedule() · Jesper Nilsson <jesper.nilsson@axis.com>
On Mon, 2011-01-17 at 12:07 +0100, Peter Zijlstra wrote:
quoted hunk
diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c index 68034bb..7ee0fc3 100644 --- a/arch/powerpc/kernel/smp.c +++ b/arch/powerpc/kernel/smp.c@@ -128,6 +128,7 @@ static irqreturn_t call_function_action(int irq, void *data) static irqreturn_t reschedule_action(int irq, void *data) { /* we just need the return path side effect of checking need_resched */ + scheduler_ipi(); return IRQ_HANDLED; }
You missed:
diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
index 9813605..467d122 100644
--- a/arch/powerpc/kernel/smp.c
+++ b/arch/powerpc/kernel/smp.c@@ -98,6 +98,7 @@ void smp_message_recv(int msg) break; case PPC_MSG_RESCHEDULE: /* we notice need_resched on exit */ + scheduler_ipi(); break; case PPC_MSG_CALL_FUNC_SINGLE: generic_smp_call_function_single_interrupt();
Fold that in and add: Acked-by: Benjamin Herrenschmidt <redacted> (We have two variants of the IPIs) Cheers, Ben.