Re: Please test my alpha tree
From: Matt Turner <mattst88@gmail.com>
Date: 2011-01-17 04:37:13
On Wed, Jan 12, 2011 at 9:54 PM, Ivan Kokshaysky [off-list ref] wrote:
On Thu, Jan 13, 2011 at 10:10:12AM +1300, Michael Cree wrote:quoted
On 12/01/11 18:29, Matt Turner wrote:quoted
On boot-up of my UP1500, I see HWRPB cycle frequency bogus. Estimated 796423805 Hz Trying to install interrupt handler for IRQ8 ------------[ cut here ]------------ WARNING: at kernel/softirq.c:138 __local_bh_enable+0xa8/0xc0()I don't think that's related to the __do_IRQ removal. It occurs in the 2.6.37 kernel just released. Was discussed on linux-alpha with no resolution; see http://marc.info/?l=linux-alpha&m=128859282018188&w=2 and following messages in thread.Fixed, the patch will follow shortly.quoted
quoted
Ivan, the last patch in my tree is a breakage fix that you proposed. It seems fine to me; can you please give your sign-off?The commit message should give more information. How about the following? Commit df9ee29270 made arch_local_irq_save and arch_local_irq_restore static inline which with -Werror trips up on __set_hae() and _set_hae() which are extern inline. The naive solution is to make __set_hae() and set_hae() static inline but for reasons described in commit d559d4a24a3fe this breaks the generic kernel build. Instead, since this is architecture specific code, this patch hard wires in the architecture specific method of disabling and enabling interrupts.Agreed, that would be nice description.quoted
You can also add my Tested-by (I tested on generic, miata and dp264 kernel builds).Matt, feel free to add Signed-off-by: Ivan Kokshaysky [off-list ref] Ivan.
Thanks Ivan! I've updated this patch with your tag. Matt -- To unsubscribe from this list: send the line "unsubscribe linux-alpha" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html