Re: [PATCH 2/3] aerdrv: Enhanced AER logging
From: Steven Rostedt <rostedt@goodmis.org>
Date: 2012-11-30 01:53:52
Also in:
linux-pci, lkml
On Thu, 2012-11-29 at 14:54 -0700, Lance Ortiz wrote:
quoted hunk ↗ jump to hunk
--- a/drivers/pci/pcie/aer/aerdrv_errprint.c +++ b/drivers/pci/pcie/aer/aerdrv_errprint.c@@ -23,6 +23,10 @@ #include "aerdrv.h" +#define CREATE_TRACE_POINTS +#define TRACE_INCLUDE_PATH ../../../../include/ras +#include <ras/aer_event.h> +
Yuck yuck yuck! This header should be in the same directory, and you should have in that same header: #undef TRACE_INCLUDE_PATH #define TRACE_INCLUDE_PATH . and remove the definition here. -- Steve
quoted hunk ↗ jump to hunk
#define AER_AGENT_RECEIVER 0 #define AER_AGENT_REQUESTER 1 #define AER_AGENT_COMPLETER 2@@ -194,6 +198,8 @@ void aer_print_error(struct pci_dev *dev, struct aer_err_info *info) if (info->id && info->error_dev_num > 1 && info->id == id) printk("%s"" Error of this Agent(%04x) is reported first\n", prefix, id); + trace_aer_event(dev_name(&dev->dev), (info->status & ~info->mask), + info->severity); }