RE: [PATCH 2/3] aerdrv: Enhanced AER logging

Yup.  You are right.  I thought I had it enabled, I will send out the new patch soon.

Lance

-----Original Message-----
From: Joe Perches [mailto:joe@perches.com]
Sent: Thursday, November 29, 2012 3:12 PM
To: Ortiz, Lance E
Cc: bhelgaas@google.com; lance_ortiz@hotmail.com; jiang.liu@huawei.com;
tony.luck@intel.com; bp@alien8.de; rostedt@goodmis.org;
mchehab@redhat.com; linux-acpi@vger.kernel.org; linux-
pci@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] aerdrv: Enhanced AER logging

On Thu, 2012-11-29 at 14:54 -0700, Lance Ortiz wrote:

quoted

This patch will provide a more reliable and easy way for user-space
applications to have access to AER logs rather than reading them from

the

quoted

message buffer. It also provides a way to notify user-space when an

AER

quoted

event occurs.

[]

quoted

diff --git a/drivers/acpi/apei/cper.c b/drivers/acpi/apei/cper.c
index e6defd8..ef1e1c0 100644
--- a/drivers/acpi/apei/cper.c
+++ b/drivers/acpi/apei/cper.c

@@ -281,9 +281,16 @@ static void cper_print_pcie(const char *pfx,

const struct cper_sec_pcie *pcie,

quoted

 	"%s""bridge: secondary_status: 0x%04x, control: 0x%04x\n",
 	pfx, pcie->bridge.secondary_status, pcie->bridge.control);
 #ifdef CONFIG_ACPI_APEI_PCIEAER
-	if (pcie->validation_bits & CPER_PCIE_VALID_AER_INFO) {
+	dev = pci_get_domain_bus_and_slot(pcie->device_id.segment,
+			pcie->device_id.bus, pcie->device_id.function);
+	if (!dev)
+		pr_info(KERN_INFO, "PCI AER Cannot get PCI device

%04x:%02x:%02x.%d\n",

quoted

+			domain, bus, slot, func);

You've not tried this with CONFIG_ACPI_APEI_PCIEAER enabled.

		pr_info("PCI AER Cannot get PCI device
%04x:%02x:%02x.%d\n",
			domain, bus, slot, func);