Thread (89 messages) 89 messages, 8 authors, 2012-11-30

Re: [PATCH v2 3/3 UPDATED] i2c / ACPI: add ACPI enumeration support

From: Jean Delvare <hidden>
Date: 2012-11-16 18:13:12
Also in: lkml

On Fri, 16 Nov 2012 19:28:28 +0200, Mika Westerberg wrote:
On Fri, Nov 16, 2012 at 05:47:53PM +0100, Jean Delvare wrote:
quoted
Hi Mika,

On Fri, 16 Nov 2012 17:23:32 +0200, Mika Westerberg wrote:
quoted
Here's the updated version where we handle 10-bit addresses properly
(hopefully).
(...)
+static int acpi_i2c_find_device(struct device *dev, acpi_handle *handle)
+{
(...)
+	memset(&i2c_find, 0, sizeof(i2c_find));
+	i2c_find.addr = client->addr;
+	if (client->flags & I2C_CLIENT_TEN)
+		i2c_find.access_mode = ACPI_I2C_10BIT_MODE;
This works because you are lucky and ACPI_I2C_7BIT_MODE has value 0,
but for correctness I'd rather add:

	else
		i2c_find.access_mode = ACPI_I2C_7BIT_MODE;
Right, sorry about that. The patch below should address this as well.
(...)
Yes, looks good.

-- 
Jean Delvare
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help