Thread (5 messages) 5 messages, 2 authors, 2011-08-30

Re: [PATCH] ACPI, APEI, Print resource errors in conventional format

From: Bjorn Helgaas <bhelgaas@google.com>
Date: 2011-08-30 16:32:46

On Mon, Aug 29, 2011 at 6:41 PM, Huang Ying [off-list ref] wrote:
On 08/29/2011 10:08 PM, Bjorn Helgaas wrote:
quoted
On Sun, Aug 28, 2011 at 6:49 PM, Huang Ying [off-list ref] wrote:
quoted
On 08/27/2011 01:10 AM, Bjorn Helgaas wrote:
quoted
Use the normal %pR-like format for MMIO and I/O port ranges.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
 drivers/acpi/apei/apei-base.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/acpi/apei/apei-base.c b/drivers/acpi/apei/apei-base.c
index 8041248..8bd5f1a 100644
--- a/drivers/acpi/apei/apei-base.c
+++ b/drivers/acpi/apei/apei-base.c
@@ -460,9 +460,9 @@ int apei_resources_request(struct apei_resources *resources,
                                     desc);
              if (!r) {
                      pr_err(APEI_PFX
-             "Can not request iomem region <%016llx-%016llx> for GARs.\n",
+             "Can not request [mem %#010llx-%#010llx] for %s registers\n",
Why %#010llx instead of %#016llx?
Because %#010llx is effectively what we use for %pR.  Two characters
for "0x", then eight for the value.  IMHO, sixteen uninterrupted hex
characters is too hard to read.
That is reasonable. Thanks.

Acked-by: Huang Ying <redacted>
Disregard this patch; I'll send a v2 that does the same for another APEI file.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help