Re: [PATCH] ACPI, APEI, Print resource errors in conventional format
From: Huang Ying <hidden>
Date: 2011-08-30 00:41:39
On 08/29/2011 10:08 PM, Bjorn Helgaas wrote:
On Sun, Aug 28, 2011 at 6:49 PM, Huang Ying [off-list ref] wrote:quoted
On 08/27/2011 01:10 AM, Bjorn Helgaas wrote:quoted
Use the normal %pR-like format for MMIO and I/O port ranges. Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> --- drivers/acpi/apei/apei-base.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)diff --git a/drivers/acpi/apei/apei-base.c b/drivers/acpi/apei/apei-base.c index 8041248..8bd5f1a 100644 --- a/drivers/acpi/apei/apei-base.c +++ b/drivers/acpi/apei/apei-base.c@@ -460,9 +460,9 @@ int apei_resources_request(struct apei_resources *resources, desc); if (!r) { pr_err(APEI_PFX - "Can not request iomem region <%016llx-%016llx> for GARs.\n", + "Can not request [mem %#010llx-%#010llx] for %s registers\n",Why %#010llx instead of %#016llx?Because %#010llx is effectively what we use for %pR. Two characters for "0x", then eight for the value. IMHO, sixteen uninterrupted hex characters is too hard to read.
That is reasonable. Thanks. Acked-by: Huang Ying <redacted> Best Regards, Huang Ying