Re: [PATCH v8 19/46] KVM: guest_memfd: Use actual size for invalidation in kvm_gmem_release()
From: sashiko-bot@kernel.org
Date: 2026-06-19 00:49:19
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The commit message incorrectly references `__kvm_gmem_invalidate_begin()` instead of the actual function name `__kvm_gmem_invalidate_start()`. -- commit 50ac1910099f66ea81813150ac7efe43b67fe2df Author: Ackerley Tng [off-list ref] KVM: guest_memfd: Use actual size for invalidation in kvm_gmem_release() This commit modifies kvm_gmem_release to calculate the actual size of the guest_memfd inode. This size is then used as the end range for invalidating SPTEs instead of relying on -1ul.
__kvm_gmem_invalidate_begin() and __kvm_gmem_invalidate_end() actually do not specially handle -1ul. -1ul is used as a huge number, which legal indices do not exceed, and hence the invalidation works as expected.
[Severity: Low] This isn't a bug, but should the commit message reference __kvm_gmem_invalidate_start instead of __kvm_gmem_invalidate_begin? The underlying function in the code appears to be named __kvm_gmem_invalidate_start. -- Sashiko AI review · https://sashiko.dev/#/patchset/20260618-gmem-inplace-conversion-v8-0-9d2959357853@google.com?part=19