Thread (61 messages) 61 messages, 6 authors, 2021-03-10

Re: [PATCH 02/25] x86/cpufeatures: Add SGX1 and SGX2 sub-features

From: Borislav Petkov <bp@alien8.de>
Date: 2021-03-01 12:00:05
Also in: lkml

On Tue, Mar 02, 2021 at 12:43:06AM +1300, Kai Huang wrote:
To confirm, if we suppress both "sgx1" and "sgx2" in /proc/cpuinfo, we
don't need to add "why to suppress" in commit message, right?
You should always explain in a patch why you're doing the change. So
that a reviewer knows. And then people in the future can follow why
you've made that decision. Always.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help